This repository has been archived by the owner on May 10, 2022. It is now read-only.
fix: fix block bug of InetAddressValidator.getInstance() #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Nov 7, 2019
src/main/java/com/xiaomi/infra/pegasus/rpc/async/HostNameResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/HostNameResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/MetaSession.java
Outdated
Show resolved
Hide resolved
neverchanje
changed the title
neverchanje
approved these changes
Nov 7, 2019
foreverneverer
added a commit
to foreverneverer/pegasus-java-client
that referenced
this pull request
Nov 7, 2019
foreverneverer
added a commit
that referenced
this pull request
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS域名功能为了检测域名地址格式的有效性，使用了Apache 的
commons-validator包的InetAddressValidator.getInstance().isValid方法，其中InetAddressValidator.getInstance()在某些机器上可能会引起阻塞。目前并未发现引起阻塞的原因，该PR更换成了Guava包，该bug并未出现。