This repository has been archived by the owner on May 10, 2022. It is now read-only.
feat: have package version prefixed in PException #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
foreverneverer,
acelyc111,
hycdong,
levy5307 and
qinzuoyan
foreverneverer
approved these changes
Nov 5, 2019
foreverneverer
pushed a commit
to foreverneverer/pegasus-java-client
that referenced
this pull request
Nov 7, 2019
foreverneverer
pushed a commit
that referenced
this pull request
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package version is necessary for debugging our clients in Xiaomi, where hundreds of users are using pegasus-java-client in different versions. Some may misuse but insist they are using the latest version (usually with less bugs). With version included in
PException, we can save time for digging down to the root cause.How does it work
We use maven-jar-plugin to inject the version during packaging. To obtain the version we use
When unit test the version is set "{version}" as a place-holder.
Finally the exception message of a PException is like: