This repository has been archived by the owner on May 10, 2022. It is now read-only.
feat: add more exception info on synchronous APIs #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个pr就不加版本信息了是吗？ |
|
下个PR加吧，版本很重要，在新的PR加比较好 |
foreverneverer
previously approved these changes
Nov 2, 2019
foreverneverer
approved these changes
Nov 4, 2019
foreverneverer
pushed a commit
to foreverneverer/pegasus-java-client
that referenced
this pull request
Nov 7, 2019
foreverneverer
pushed a commit
that referenced
this pull request
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most synchronous APIs of PegasusTable, when
Future.awaitthrowsInterruptedExceptionandTimeoutException, they are wrapped under PException with simply coded ERR_TIMEOUT. This makes it hard to distinguish the real problem.So here we add more details on each exception, InterruptedException is coded ERR_THREAD_INTERRUPTED, and information like "tableName" and "timeout ms" is complemented.