This repository has been archived by the owner on May 10, 2022. It is now read-only.
fix: handle case where Future.cause() is null in FutureGroup #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2019 16:39
qinzuoyan
reviewed
Aug 21, 2019
| @@ -72,7 +72,7 @@ function java_client_get_next_version() | |||
| esac | |||
|
|
|||
| if [ ${versions[2]} == "SNAPSHOT" ]; then | |||
| echo ${versions[0]}.${versions[1]}.SNAPSHOT-$staging_branch | |||
| echo ${versions[0]}.${versions[1]}-$staging_branch-SNAPSHOT | |||
There was a problem hiding this comment.
nexus 只把末尾是 snapshot 的当做 snapshot 包。
1.12.SNAPSHOT 是 snapshot，但是 1.12.SNAPSHOT-thrift-0.11.0-inlined 会被认作是 release。1.12-thrift-0.11.0-inlined-SNAPSHOT 就是正确的 snapshot。亲测。
There was a problem hiding this comment.
那么pom.xml里面现在也要改为 1.12-thrift-0.11.0-inlined-SNAPSHOT 吧
qinzuoyan
approved these changes
Aug 22, 2019
neverchanje
changed the title
neverchanje
pushed a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitAllCompleteOrOneFailwill throwNullPointExceptionwhen timeout expired in current implementation. BecauseFuture.cause()could be null when the result is not available in time.This SNAPSHOT version was deployed on one of our users' environment (c3srv-xiaoai/ai_profile_data).