This repository has been archived by the owner on May 10, 2022. It is now read-only.
add createClient API with clientOptions #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
requested review from
qinzuoyan,
neverchanje,
acelyc111,
hycdong,
zhangyifan27,
vagetablechicken and
mentoswang
|
只提供meta_server和timeout么?其他的config，例如workers，counter相关的参数呢？ |
qinzuoyan
reviewed
May 20, 2019
|
|
||
| public class ClientOptions { | ||
| String metaServers = "127.0.0.1:34601,127.0.0.1:34602,127.0.0.1:34603"; | ||
| int timeout = 1000; |
There was a problem hiding this comment.
为了和operation_timeout 保持一致，用operationTimeout更好
| package com.xiaomi.infra.pegasus.client; | ||
|
|
||
| public class ClientOptions { | ||
| String metaServers = "127.0.0.1:34601,127.0.0.1:34602,127.0.0.1:34603"; |
There was a problem hiding this comment.
还有几个options都加上吧：
- async_workers
- enable_perf_counter
- perf_counter_tags
- push_counter_interval_secs
neverchanje
reviewed
May 23, 2019
|
另外配置项需要是 private final 的，构造的时候用 builder 模式，我建议你参照 https://github.com/lettuce-io/lettuce-core/blob/master/src/main/java/io/lettuce/core/ClientOptions.java 来重写。 |
|
已经修改，并使用builder模式重构 @qinzuoyan @neverchanje @hycdong @vagetablechicken |
neverchanje
reviewed
May 24, 2019
| import java.time.Duration; | ||
|
|
||
| /** | ||
| * @author jiashuo1 |
qinzuoyan
previously approved these changes
May 27, 2019
qinzuoyan
approved these changes
May 27, 2019
neverchanje
approved these changes
May 27, 2019
neverchanje
pushed a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加了createClient(clientOptions) 、getSingletonClient(clientOptions)接口，使得用户可以直接传入配置参数（而不用写配置文件）就可以创建client
该功能为小米大数据临时需求。