Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

add travis ci support and checkstyle to enforce code style #35

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

neverchanje
Copy link

@neverchanje neverchanje commented Jan 21, 2019

几个文件的改动解释一下:

  • 新增 .travis.yml:跑 jdk8 的测试,亲测 jdk11 无法编译,后续修复,travis 不支持 oracle-jdk10(因为 jdk10 不是 long term support version)
  • 新增 scripts/travis.sh:跑 shellcheck,跑 mvn clean test
  • 新增 dev-support/checkstyle-suppressions.xml / dev-support/google-checks.xml:checkstyle 是一个 linter,可以做代码规范检查,我们这里使用 google java style。因为很多文件暂时还不符合规范,所以在 suppresion.xml 里暂时屏蔽这些报错,后续有时间可以修复。
  • 新增 scripts/format-all.sh:代码格式化,方便开发统一,这里使用 google-java-format 做格式化
  • 新增 dev-support/findbugs-exclude.xml,我们可以使用 findbugs 静态检查工具找出代码里面潜在的问题,绝大多数 java 项目都引入了这个工具,现在我们暂时屏蔽它的报错,等后面有时间修复

@neverchanje neverchanje merged commit 5890bf5 into XiaoMi:thrift-0.11.0-inlined Jan 21, 2019
@neverchanje neverchanje deleted the format branch January 21, 2019 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants