Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

feat: add a batch get client interface which uses 'BATCH_GET' rpc for read optimization #175

Merged
merged 9 commits into from
Mar 3, 2022

Conversation

cauchy1988
Copy link
Contributor

@cauchy1988 cauchy1988 commented Feb 8, 2022

corresponding server side issue is : apache/incubator-pegasus#884

this newly added client interface firstly split the needed read items into groups according to related partition and then fetch every grouped-data from 'BATCH_GET' rpc

@cauchy1988 cauchy1988 changed the title add batchGet3 client interface feat: add batchGet3 client interface Feb 8, 2022
@levy5307
Copy link
Contributor

levy5307 commented Feb 16, 2022

In my opinion, the name of batchGet3 is not good enough. Better to make it more clear.

@cauchy1988 cauchy1988 changed the title feat: add batchGet3 client interface feat: add a batch get client interface which firstly split the needed read items into groups according to related partition and then fetch every grouped-data from 'BATCH_GET' rpc Feb 16, 2022
@foreverneverer
Copy link
Contributor

add a batch get client interface which firstly split the needed read items into groups according to related partition and then fetch every grouped-data from 'BATCH_GET' rpc

title is too lang, the detail that you should add into description

@foreverneverer
Copy link
Contributor

In my opinion, the name of batchGet3 is not good enough. Better to make it more clear.

Yeah, but It's a little hard to name. groupGet or batchGetGroup..... this maybe still not good

@cauchy1988 cauchy1988 changed the title feat: add a batch get client interface which firstly split the needed read items into groups according to related partition and then fetch every grouped-data from 'BATCH_GET' rpc feat: add a batch get client interface which uses 'BATCH_GET' rpc for read optimization Mar 1, 2022
@cauchy1988
Copy link
Contributor Author

In my opinion, the name of batchGet3 is not good enough. Better to make it more clear.

Yeah, but It's a little hard to name. groupGet or batchGetGroup..... this maybe still not good

what about batchGetByPartition ?

@cauchy1988
Copy link
Contributor Author

add a batch get client interface which firstly split the needed read items into groups according to related partition and then fetch every grouped-data from 'BATCH_GET' rpc

title is too lang, the detail that you should add into description

ok

@cauchy1988
Copy link
Contributor Author

cauchy1988 commented Mar 1, 2022

batchGetByPartition

batchGetGroupByPartition?

batchGetByPartition ? is this name ok? @acelyc111 @levy5307 @shuo-jia

@foreverneverer
Copy link
Contributor

batchGetByPartition ? is this name ok? @acelyc111 @levy5307 @shuo-jia

+1

@acelyc111
Copy link
Member

How about batchGetByPartitions, since this request is on multiple partions.

@acelyc111 acelyc111 merged commit fe4bfa2 into XiaoMi:master Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants