-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add a batch get client interface which uses 'BATCH_GET' rpc for read optimization #175
Conversation
In my opinion, the name of batchGet3 is not good enough. Better to make it more clear. |
src/test/java/com/xiaomi/infra/pegasus/client/TestBatchGet3.java
Outdated
Show resolved
Hide resolved
d3f0d43
to
b454771
Compare
src/main/java/com/xiaomi/infra/pegasus/client/PegasusClientInterface.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
title is too lang, the detail that you should add into |
Yeah, but It's a little hard to name. |
what about batchGetByPartition ? |
ok |
batchGetGroupByPartition? batchGetByPartition ? is this name ok? @acelyc111 @levy5307 @shuo-jia |
+1 |
How about batchGetByPartitions, since this request is on multiple partions. |
corresponding server side issue is : apache/incubator-pegasus#884
this newly added client interface firstly split the needed read items into groups according to related partition and then fetch every grouped-data from 'BATCH_GET' rpc