This repository has been archived by the owner on May 10, 2022. It is now read-only.
feat(security): handle challenge from server #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
previously approved these changes
Nov 25, 2020
neverchanje
reviewed
Nov 25, 2020
Comment on lines
388
to
404
| public void setAuthSucceed() { | ||
| Queue<RequestEntry> swappedPendingSend = new LinkedList<>(); | ||
| synchronized (authPendingSend) { | ||
| authSucceed = true; | ||
| swappedPendingSend.addAll(authPendingSend); | ||
| authPendingSend.clear(); | ||
| } | ||
|
|
||
| while (!swappedPendingSend.isEmpty()) { | ||
| RequestEntry e = swappedPendingSend.poll(); | ||
| if (pendingResponse.get(e.sequenceId) != null) { | ||
| write(e, fields); | ||
| } else { | ||
| logger.info("{}: {} is removed from pending, perhaps timeout", name(), e.sequenceId); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I told you, your auth code is intrusive to replica session, again...
There was a problem hiding this comment.
Yes, but it's the same thing with we talk, which I add a authPendingSendin ReplicaSession. We can refactor it in the later.
This reverts commit 89672ba.
foreverneverer
approved these changes
Nov 25, 2020
neverchanje
approved these changes
Nov 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.