This repository has been archived by the owner on May 10, 2022. It is now read-only.
feat(security): handle list mechanism response #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Oct 12, 2020
| import javax.security.auth.Subject; | ||
| import javax.security.sasl.Sasl; | ||
| import org.slf4j.Logger; | ||
|
|
||
| public class Negotiation { | ||
| private static final Logger logger = org.slf4j.LoggerFactory.getLogger(Negotiation.class); | ||
| // Because negotiation message is always the first rpc sent to pegasus server, | ||
| // which will cost much more time. so we set negotiation timeout to 10s here | ||
| private static final int negotiationTimeoutMS = 10000; |
There was a problem hiding this comment.
Negotiation should be set dynamically by the user timeout. It's under the user's control that how long an RPC should last.
There was a problem hiding this comment.
I don't think it must under the user's control. The negotiation process should be not visable to users
src/main/java/com/xiaomi/infra/pegasus/rpc/async/Negotiation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/SaslWrapper.java
Outdated
Show resolved
Hide resolved
src/test/java/com/xiaomi/infra/pegasus/rpc/async/NegotiationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/SaslWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/Negotiation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/Negotiation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/Negotiation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/Negotiation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/Negotiation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/Negotiation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/interceptor/SecurityReplicaSessionInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/ReplicaSession.java
Outdated
Show resolved
Hide resolved
src/test/java/com/xiaomi/infra/pegasus/rpc/async/NegotiationTest.java
Outdated
Show resolved
Hide resolved
…-client into on_recv_mechanisms
src/test/java/com/xiaomi/infra/pegasus/rpc/async/NegotiationTest.java
Outdated
Show resolved
Hide resolved
foreverneverer
previously approved these changes
Oct 16, 2020
foreverneverer
previously approved these changes
Nov 13, 2020
neverchanje
reviewed
Nov 17, 2020
src/main/java/com/xiaomi/infra/pegasus/rpc/async/SaslWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/interceptor/ReplicaSessionInterceptor.java
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/interceptor/ReplicaSessionInterceptorManager.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Nov 17, 2020
Comment on lines
388
to
406
| // return value: | ||
| // true - pend succeed | ||
| // false - pend failed | ||
| public boolean tryPendRequest(RequestEntry entry) { | ||
| // double check. the first one doesn't lock the lock. | ||
| // Because negotiationSucceed only transfered from false to true. | ||
| // So if it is true now, it will not change in the later. | ||
| // But if it is false now, maybe it will change soon. So we should use lock to protect it. | ||
| if (!this.negotiationSucceed) { | ||
| synchronized (negotiationPendingSend) { | ||
| if (!this.negotiationSucceed) { | ||
| negotiationPendingSend.offer(entry); | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
-
Your design here binds the responsibility of negotiation to ReplicaSession again. Why couldn't ReplicaSessionInterceptor hold the pending queue?
-
negotiationPendingSend is declared final, but you offer items here.
There was a problem hiding this comment.
It's hard to hold pending queue by ReplicaSessionInterceptor.
ReplicaSessionInterceptoris a singleton, which will serves all of the ReplicaSession. So if we do this like you said, we must use a coarse-grained lock, which will produce low effiency- If we use
ReplicaSessionInterceptorto do this, we must implement a lot of logic in it. For example timeout handling, which will mantain a timeout pendingResponse queue and a PendingSend, and so on. It's too complicated, and there is a lot of overlap code with ReplicaSession. And we should modify ReplicaSession to support it.
neverchanje
approved these changes
Nov 19, 2020
foreverneverer
approved these changes
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.