-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support multi gaea proxy cluster isolation #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM, thanks for your contribution!
etc/gaea.ini
Outdated
@@ -39,5 +42,8 @@ session_timeout=3600 | |||
;stats conf | |||
stats_enabled=true | |||
|
|||
;stats interval of connect pool,unit: second | |||
stats_interval=15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this field not in use?
@@ -70,6 +76,13 @@ func ParseProxyConfigFromFile(cfgFile string) (*Proxy, error) { | |||
if proxyConfig.ConfigType == "" { | |||
proxyConfig.ConfigType = ConfigEtcd | |||
} | |||
if proxyConfig.Cluster == "" && proxyConfig.CoordinatorRoot == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which field is using when both cluster_name
and coordinator_root
are set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use cluster_name when both cluster_name and coordinator_root are set
#72