Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multi gaea proxy cluster isolation #73

Merged
merged 5 commits into from
Apr 24, 2020
Merged

support multi gaea proxy cluster isolation #73

merged 5 commits into from
Apr 24, 2020

Conversation

chicliz
Copy link
Contributor

@chicliz chicliz commented Apr 24, 2020

#72

Copy link
Contributor

@teckick teckick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM, thanks for your contribution!

etc/gaea.ini Outdated
@@ -39,5 +42,8 @@ session_timeout=3600
;stats conf
stats_enabled=true

;stats interval of connect pool,unit: second
stats_interval=15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this field not in use?

@@ -70,6 +76,13 @@ func ParseProxyConfigFromFile(cfgFile string) (*Proxy, error) {
if proxyConfig.ConfigType == "" {
proxyConfig.ConfigType = ConfigEtcd
}
if proxyConfig.Cluster == "" && proxyConfig.CoordinatorRoot == "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which field is using when both cluster_name and coordinator_root are set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use cluster_name when both cluster_name and coordinator_root are set

@teckick teckick changed the title [gaea proxy] support multi gaea proxy cluster isolation support multi gaea proxy cluster isolation Apr 24, 2020
@teckick teckick merged commit c89be66 into XiaoMi:master Apr 24, 2020
@teckick teckick linked an issue Apr 24, 2020 that may be closed by this pull request
panhongrainbow pushed a commit to panhongrainbow/Gaea that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi cluster support in gaea-proxy
2 participants