Check for custom properties #254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kagaminara
force-pushed
the
check-for-custom-properties
branch
from
ac52556 to
4932e94
Compare
|
Hey, @Kagaminara, thanks for the PR! Unfortunately, the button to update your PR is not enabled. Please allow edit from maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
We wanted to be able to check for unused SASS variables as well as CSS custom properties, so that none of those are missed out.
This MR adds checks for CSS custom properties (
--myVarsyntax) to find-unused-sass-variables, and also updates the existing tests to add some custom properties in the batch.The script usage stays the same, and custom properties can now be passed in the
--ignoreargument, like so:Please let me know what you think about it, and if you see other possible improvements on this take !