Codestyle PRs

[tinovyatkin]

I just took a look for the library source code and wondering why the code-style is so strange, mixed and outdated. Your node version requirement in package.json is current LTS (6.0) and that's great, but platform/language features usage seems to be targeting something like node 0.12.

For example: https://github.com/XeroAPI/xero-node/blob/master/lib/application.js - you have const within function declarations, but missing use strict anywhere and top level variables declared as var.

Question is: will you accept refactoring pull requests? I'm particularly interesting in getting rid of lodash as it's huge stone age dependency...

[philals]

What about a road map on the README.md? Then contributors can pick up tasks.

Ideas to start with:

• Add ESLint rules
• ESLint rule complaint
• Remove log4js
• Throw exceptions with messages
• Remove lodash

I can open a PR with these changes we think it's a good idea.

[jordanwalsh23]

Yes.. totally supportive of a roadmap like this. The code was merged and updated from a project about 3 years ago, so still lots of cleanup to do. Also, I'm not a node native. So ES2016/ES2017 vs old JS are still new to me. Very keen to learn from the community on what the appropriate standards are today, so yes totally if you see something you'd like to fix up, submit a PR and we'll get it merged.

…

On 26 Jul. 2017 5:45 am, "Phil Alsford" ***@***.***> wrote: What about a road map on the README.md? Then contributors can pick up tasks. Ideas to start with: - Add ESLint rules - ESLint rule complaint - Remove log4js - Throw exceptions with messages - Remove lodash I can open a PR with these changes we think it's a good idea. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUxiBNnKrHOOWv8nLY27n1dAxw0tVDAks5sRkXOgaJpZM4OimhG> .

[philals]

Here we go @jordanwalsh23 and @tinovyatkin

#61 Adds a quick road map, which hopefully will encourage the community to PR on the old code.

[tinovyatkin]

Great! I think ESLint is essential for productive collaboration, so, will start with that small PR.

[philals]

Nice @tinovyatkin. I think ESLint will give the greatest benefit.

Thanks.

I guess you get to choose the style to go with.

[tinovyatkin]

Well, I have a great experience with airbnb rules set + eslint-prettier, but whatever you prefer it's more important for me to have it automatically enforced in the project via tooling.

[philals]

I agree with you. Does not matter what it is, as long as it's there and automated.

airbnb and eslint-prettier will be great.

[tinovyatkin]

Submitted #63

[jordanwalsh23]

This has been merged. Closing the issue.