Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/docker setup mac #144

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bug/docker setup mac #144

wants to merge 4 commits into from

Conversation

vasynizami
Copy link
Contributor

@vasynizami vasynizami commented Dec 2, 2020

Fixing issues after PR 132


This change is Reviewable

@vasynizami vasynizami requested a review from codecakes December 2, 2020 22:18
<Switch>
<Route exact path="/" component={Home} />
<Route path="/search/:lat/:lng" component={Search} />
</Switch>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclosed regular expression.
Unrecoverable syntax error. (89% scanned).

@@ -8,8 +8,18 @@ import {
COOKIEBOT_CONSENT_HEAD_DATA_CBID,
TAWKTO,
} from "./constants/index";
import * as Socks from 'react-socks';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@gitpod-io
Copy link

gitpod-io bot commented Dec 2, 2020

Copy link
Contributor

@codecakes codecakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there two different features in this PR? besides updating readme?

@@ -14,4 +14,5 @@ services:
- "/app/node_modules"
environment:
- PORT=9119
- CHOKIDAR_USEPOLLING="true"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing L17 from master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants