-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python code examples #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks wonderful! I love how the sphinx tabs work.
All my comments are minor so I'm happy to approve. The only one that should be addressed is that the sphinx docs keep referring to 'installation instructions', however every link seems broken. It is currently pointed to /use/installing.html
? I also couldn't find installation instructions in the ToC?
Oh, I just realized it should be pointing to the Development Guide? As a 'user' that wants to install Jet but not develop for it, I kept looking for an 'Install' or 'Getting Started' page in the 'Using Jet' section.
Co-authored-by: Josh Izaac <[email protected]>
Awesome!
Thanks for catching that - it's fixed now.
Ah, you can find those instructions under "Development Guide" (similar to SF).
I agree with you although neither PL or SF have an explicit section in the ToC for installation instructions. Perhaps this is something we should change across all of the Xanadu OSS projects? |
They used to --- we since moved this to the main navbar, since we wanted to make it as accessible as possible: The Walrus is the one exception - here, it remained in the Sphinx TOC: This is (partly) because including it in the main navbar involved working out how to get Sphinx to include static pages in the build (or something like that). Doable, we just never got around to it! |
Oh, true - I forgot about the navbar! We should definitely add an "Install" link there once the main website is live since the static HTML page approach used by SF feels like a bit of a maintenance burden. |
Context:
Presently, the Using Jet section of the Sphinx documentation does not contain any Python code examples. This PR primarily adds an equivalent Python code snippet to each existing C++ code snippet using the sphinx-tabs extension.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
None