Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove license headers #14

Merged
merged 2 commits into from
May 27, 2021
Merged

Remove license headers #14

merged 2 commits into from
May 27, 2021

Conversation

Mandrenkov
Copy link
Collaborator

Context:
The files introduced in #11 included an Apache 2.0 comment header at the top of each source file; however, this is not necessary since the license [can] be included by reference instead of listed in every file.

Description of the Change:

  • There are no longer any license comment headers in the Jet repository.

Benefits:

  • Slightly reduced maintenance burden.
  • Marginal reduction in source code size.

Possible Drawbacks:

  • The repository is less consistent with PennyLane and Strawberry Fields.

Related GitHub Issues:
None.

@Mandrenkov Mandrenkov added the documentation 📚 Improvements or additions to documentation label May 25, 2021
@Mandrenkov Mandrenkov requested review from thisac and brownj85 May 25, 2021 20:34
@github-actions
Copy link

github-actions bot commented May 25, 2021

Test Report (C++) on Ubuntu

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
239 tests ±0  239 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
519 runs  ±0  519 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 73bdb34. ± Comparison against base commit 73bdb34.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 25, 2021

Test Report (C++) on MacOS

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 73bdb34. ± Comparison against base commit 73bdb34.

♻️ This comment has been updated with latest results.

Copy link

@thisac thisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this! 👍

@Mandrenkov Mandrenkov merged commit 73bdb34 into main May 27, 2021
@Mandrenkov Mandrenkov deleted the remove-license-headers branch May 27, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📚 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants