Assume row-major order for indices #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-vincent
approved these changes
May 20, 2021
mlxd
added a commit
that referenced
this pull request
May 21, 2021
* Replace terminate with throw * Add Jet exception and implement tests * Remove code paths protected by static_assert * Update testing to check exception output * Update Abort docstrings * Add tests for Abort.hpp * Fix linting of tests * Remove unneeded function * Update JetException docstring * Fix linting * Remove Fatal word * Rename invalid_tensor_file and extend from JetException * Update CHANGELOG * Assume row-major order for indices (#10) * Switch multi-index to row-major order * Replace 'utilities' tag with 'Utilities' * Fix tests specifying indices in column-major order * Update changelog * Fix Python unit test using column-major indices * Undo modification to previous changelog entry * Fix PR number * Update change-log * Fix Abort formatting and tests * Rename JetException and avoid naming collisions * Fix class name in changelog * Trigger CI Co-authored-by: Mikhail Andrenkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The modern convention is to specify indices in row-major order; however, Jet expects indices to be in column-major order.
Description of the Change:
RavelIndex()andUnravelIndex()now assume indices are specified in row-major order.shapehas one entry) has been removed.ShapeToSize()function has been moved from TensorHelpers.hpp to Utilities.hpp.[utilities]tag has been replaced with[Utilities]for the sake of consistency.Benefits:
Possible Drawbacks:
Related GitHub Issues:
None.