Small cleanup around exceptions (#1721)

Xabaril · Mar 1, 2023 · 35225ad · 35225ad
1 parent 8ec597b
commit 35225ad
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,7 +1,7 @@
 <Project>
   <Import Project="build/versions.props" />
 
-  <PropertyGroup Label="Package information">
+  <PropertyGroup>
     <PackageId>AspNetCore.$(MSBuildProjectName)</PackageId>
     <PackageIcon>icon.png</PackageIcon>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>

diff --git a/src/HealthChecks.Kubernetes/KubernetesHealthCheck.cs b/src/HealthChecks.Kubernetes/KubernetesHealthCheck.cs
@@ -43,7 +43,7 @@ public async Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context
         }
         catch (Exception ex)
         {
-            return new HealthCheckResult(context.Registration.FailureStatus, ex.Message);
+            return new HealthCheckResult(context.Registration.FailureStatus, ex.Message, ex);
         }
     }
 }
diff --git a/src/HealthChecks.System/ProcessHealthCheck.cs b/src/HealthChecks.System/ProcessHealthCheck.cs
@@ -31,6 +31,6 @@ public Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context, Canc
             return Task.FromResult(new HealthCheckResult(HealthStatus.Unhealthy, exception: ex));
         }
 
-        return Task.FromResult(new HealthCheckResult(context.Registration.FailureStatus, exception: null));
+        return Task.FromResult(new HealthCheckResult(context.Registration.FailureStatus));
     }
 }
diff --git a/src/HealthChecks.System/WindowsServiceHealthCheck.cs b/src/HealthChecks.System/WindowsServiceHealthCheck.cs
@@ -30,7 +30,7 @@ public Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context, Canc
             return Task.FromResult(new HealthCheckResult(context.Registration.FailureStatus, exception: ex));
         }
 
-        return Task.FromResult(new HealthCheckResult(context.Registration.FailureStatus, exception: null));
+        return Task.FromResult(new HealthCheckResult(context.Registration.FailureStatus));
     }
 
     private ServiceController GetServiceController() =>