Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SpanOptions.AllowRoot #101

Merged
merged 6 commits into from
Jul 8, 2022
Merged

Remove SpanOptions.AllowRoot #101

merged 6 commits into from
Jul 8, 2022

Conversation

XSAM
Copy link
Owner

@XSAM XSAM commented Jul 7, 2022

Resolves #96

This PR also updates the example to indicate the parent span is optional.

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #101 (27432ab) into main (2f96852) will decrease coverage by 0.5%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #101     +/-   ##
=======================================
- Coverage   80.4%   79.9%   -0.6%     
=======================================
  Files         12      12             
  Lines        675     658     -17     
=======================================
- Hits         543     526     -17     
  Misses       107     107             
  Partials      25      25             
Impacted Files Coverage Δ
config.go 90.0% <ø> (ø)
conn.go 77.7% <100.0%> (-1.2%) ⬇️
connector.go 100.0% <100.0%> (ø)
rows.go 55.8% <100.0%> (-0.7%) ⬇️
stmt.go 78.9% <100.0%> (-1.4%) ⬇️
tx.go 100.0% <100.0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f96852...27432ab. Read the comment docs.

@XSAM XSAM merged commit fd65901 into main Jul 8, 2022
@XSAM XSAM deleted the remove-spanoptions-allowroot branch July 8, 2022 01:28
This was referenced Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SpanOptions AllowRoot
1 participant