Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix network ID tests + refactor network ID logic #655

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Oct 3, 2023

High Level Overview of Change

Title says it all.

Context of Change

Tests are failing because the sidechain devnet no longer has a network ID greater than 1024.

Type of Change

  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

The network ID tests now work.

Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckniffen ckniffen merged commit 7ba9fa7 into master Oct 5, 2023
17 checks passed
@ckniffen ckniffen deleted the network-id-test-fix branch October 5, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants