RXI-1397 flag check for credentials #5250
Open
+63
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5250 +/- ##
=======================================
Coverage 78.0% 78.0%
=======================================
Files 789 789
Lines 66955 66967 +12
Branches 8132 8108 -24
=======================================
+ Hits 52223 52233 +10
- Misses 14732 14734 +2
... and 2 files with indirect coverage changes |
Bronek
reviewed
Jan 17, 2025
ximinez
requested changes
Jan 17, 2025
| @@ -29,6 +29,8 @@ | |||
| // If you add an amendment here, then do not forget to increment `numFeatures` | |||
| // in include/xrpl/protocol/Feature.h. | |||
|
|
|||
| // fix1782: Check flags in Credential transactions | |||
| XRPL_FIX (1782, Supported::yes, VoteBehavior::DefaultNo) | |||
There was a problem hiding this comment.
Please give this a meaningful name. We want people who don't have access to our internal ticketing system to still get some info from the name. CredentialFlags should be fine.
Bronek
approved these changes
Jan 20, 2025
|
The flag check is also missing on other transactions. Should we add the flag check to other transactions as well? I believe the other one is SignerListSet. |
|
@dangell7 makes sense, but it should be a different amendment (we do not want this amendment to be rejected by operators, because of compatibility anxiety) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add transaction flag checking functionality for Credentials
Context of Change
CredentialCreate / CredentialAccept / CredentialDelete transactions will check sfFlags field in preflight()
Type of Change