Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPC for
server_definitions
to rippled #4703Add RPC for
server_definitions
to rippled #4703Changes from 28 commits
439179d
c8f73bd
ede9634
e8ba1ef
38db68b
18cecad
2ac883e
d36cb79
54f19e3
1607c55
2ca2bb7
ff4f55d
166ab29
fd2da62
e22e3b3
423bf60
5fc2ee5
5d36478
f430626
c46a5f7
e67f72c
18edf9e
89f336a
7f53fcf
d558b66
c34bcd0
ed92a27
ebe4258
b628b42
c64bd2f
162ba8b
d8503ae
7f17a78
205c0f5
3e4b7a5
cd69226
008f092
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to note that this is a problem that the C++ language itself should solve, and there really isn't a nice, clean solution to reflection and enums. I prefer to keep our solution reasonably "magic free", and it's easy to understand what's going on with this macro solution. When we're reaching for macros the first thing we're going to want to see is if there's a better way. I know there are other solutions to this, but for this limited use-case I think macros are OK.