Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add user version of feature RPC #1131

Closed
intelliot opened this issue Jan 23, 2024 · 1 comment · Fixed by #1526
Closed

feat: add user version of feature RPC #1131

intelliot opened this issue Jan 23, 2024 · 1 comment · Fixed by #1526
Assignees
@godexsoft
Labels
compatibility
Milestone
2.3

Comments

@intelliot
Copy link
Collaborator

@intelliot intelliot added this to the 2.2 milestone Jan 23, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Jan 23, 2024
@godexsoft godexsoft self-assigned this May 7, 2024
@godexsoft godexsoft mentioned this issue May 20, 2024
Closed
This was referenced May 29, 2024
Closed
Merged
@godexsoft godexsoft removed this from the 2.2 milestone May 31, 2024
@godexsoft
Copy link
Collaborator

Removed 2.2 milestone for now as we can't implement it until support is added to libxrpl and that is not happening until after 2.2.0.
Replacing with #1440 until then.

@godexsoft godexsoft added the on hold For issues that currently wait on other issues label May 31, 2024
kuznetsss added a commit that referenced this issue Jun 11, 2024
@godexsoft @kuznetsss
Forward feature RPC (#1440)
42c970a 
Fixes #1436 

This is a temporary implementation of the `feature` RPC that will always
return `noPermission` iff `vetoed` is set.
If `vetoed` isn't specified, Clio will always forward the request to
`rippled` instead.

In the future, #1131 will implement a Clio-native `feature` RPC. This
requires specific support from `libxrpl` side and that is not going to
be available till at least 2.2.1, hence the temporary forwarding.

It would be great to review the error message and code so that we pick
the right one from the start.

Co-authored-by: Sergey Kuznetsov <[email protected]>
kuznetsss added a commit that referenced this issue Jun 18, 2024
@godexsoft @kuznetsss
Forward feature RPC (#1440)
6462323 
Fixes #1436 

This is a temporary implementation of the `feature` RPC that will always
return `noPermission` iff `vetoed` is set.
If `vetoed` isn't specified, Clio will always forward the request to
`rippled` instead.

In the future, #1131 will implement a Clio-native `feature` RPC. This
requires specific support from `libxrpl` side and that is not going to
be available till at least 2.2.1, hence the temporary forwarding.

It would be great to review the error message and code so that we pick
the right one from the start.

Co-authored-by: Sergey Kuznetsov <[email protected]>
@godexsoft godexsoft added this to the 2.3 milestone Jun 18, 2024
@godexsoft godexsoft removed the on hold For issues that currently wait on other issues label Jul 8, 2024
@godexsoft godexsoft mentioned this issue Jul 9, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Merged in Clio Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@godexsoft godexsoft

Labels
compatibility
Projects
Clio
Status: ✅ Merged
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

feat: Native Feature RPC godexsoft/clio
2 participants
@intelliot @godexsoft