Add warning for images without max-pixel #496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #475
Why is this the best possible solution? Were any other approaches considered?
It's the narrowest change. I used the shortest possible warning to make it easier to read.
Note there is one unrelated commit to make the Learn/read more consistent throughout pyxform.
What are the regression risks?
None that I can think of. It's just a warning. If you have a lot of images, you could get a lot of these warnings. I toyed with the idea of de-duping it so you only get one generic one, but I think row numbers are more helpful.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
tests_v1
nosetests
and verified all tests passblack pyxform
to format code