-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quality attribute for audio questions #483
Conversation
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 83.63% 83.67% +0.04%
==========================================
Files 25 25
Lines 3641 3651 +10
Branches 846 849 +3
==========================================
+ Hits 3045 3055 +10
Misses 452 452
Partials 144 144
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see a README section about tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
This adds support for the
quality
attribute detailed here.Why is this the best possible solution? Were any other approaches considered?
Didn't seem like there were a lot of different ways to go but definitely keen to hear criticism as I'm pretty new to the codebase.
What are the regression risks?
Only audio questions have been changed so that's the only area where something could go wrong (I'd imagine).
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Yes but that's been planned separately!
Before submitting this PR, please make sure you have:
tests_v1
nosetests
and verified all tests passblack pyxform
to format code