Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality attribute for audio questions #483

Merged
merged 4 commits into from
Dec 2, 2020

Conversation

seadowg
Copy link
Contributor

@seadowg seadowg commented Nov 18, 2020

This adds support for the quality attribute detailed here.

Why is this the best possible solution? Were any other approaches considered?

Didn't seem like there were a lot of different ways to go but definitely keen to hear criticism as I'm pretty new to the codebase.

What are the regression risks?

Only audio questions have been changed so that's the only area where something could go wrong (I'd imagine).

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Yes but that's been planned separately!

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests_v1
  • run nosetests and verified all tests pass
  • run black pyxform to format code
  • verified that any code or assets from external sources are properly credited in comments

@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #483 (880e916) into master (85582ef) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   83.63%   83.67%   +0.04%     
==========================================
  Files          25       25              
  Lines        3641     3651      +10     
  Branches      846      849       +3     
==========================================
+ Hits         3045     3055      +10     
  Misses        452      452              
  Partials      144      144              
Impacted Files Coverage Δ
pyxform/xls2json.py 78.30% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85582ef...880e916. Read the comment docs.

@seadowg seadowg marked this pull request as ready for review November 18, 2020 16:46
lognaturel
lognaturel previously approved these changes Nov 18, 2020
Copy link
Contributor

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see a README section about tests.

@lognaturel lognaturel requested a review from MartijnR November 18, 2020 19:00
MartijnR
MartijnR previously approved these changes Nov 20, 2020
Copy link
Contributor

@MartijnR MartijnR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@seadowg seadowg dismissed stale reviews from MartijnR and lognaturel via 7263e8a November 24, 2020 17:15
@seadowg seadowg requested a review from lognaturel November 24, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants