-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 471 deprecate unused device id methods #473
Merged
lognaturel
merged 7 commits into
XLSForm:master
from
KeynesYouDigIt:issue_471_deprecate_unused_device_id_methods
Oct 19, 2020
Merged
Issue 471 deprecate unused device id methods #473
lognaturel
merged 7 commits into
XLSForm:master
from
KeynesYouDigIt:issue_471_deprecate_unused_device_id_methods
Oct 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeynesYouDigIt
commented
Oct 11, 2020
KeynesYouDigIt
commented
Oct 11, 2020
lognaturel
requested changes
Oct 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
KeynesYouDigIt
force-pushed
the
issue_471_deprecate_unused_device_id_methods
branch
from
October 17, 2020 21:51
4cbd728
to
efbc95b
Compare
lognaturel
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks so much!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471
Why is this the best possible solution? Were any other approaches considered?
This adds warnings where other question type specific warnings are. This pattern is modelled after the special validation work used for 'audit' and 'calculate' question types.
I considered checking this information upstream in the survey creation process, but would have to re-divide the sheet into rows. Downstream, during question creation and final survey creation, is another place where warnings can be generated, but we have the information we need at the point where the warnings were added, so no point in working further down.
What are the regression risks?
I did modify constants.py - any modification of a global config represents some regression risk. However, values were only added, and only values that apply to my use case, and only under a name that does not conflict with another name, so I do not see any great risks.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
docs should already be set https://github.com/XLSForm/xlsform.github.io/pull/208/files
Before submitting this PR, please make sure you have:
tests_v1
nosetests
and verified all tests passblack pyxform
to format code