Reject form with unknown columns in entities sheet #669
Comments
|
Because this is about rejecting columns in the special sheets, I think it sounds nice. It would also have helped that one time I wrote |
lindsay-stevens
added a commit
to lindsay-stevens/pyxform
that referenced
this issue
Nov 28, 2023
- add tests for new error case(s) + happy path - add copy of python 3.11 StrEnum which can reference members as str - add enum with the expected entities column names - update existing entities modules to use constants
4 tasks
lognaturel
added a commit
that referenced
this issue
Nov 29, 2023
#669: reject form with unknown columns in entities sheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, unknown columns are ignored on all sheets. This is generally convenient for the
surveysheet because it makes it straightforward to add commentary or turn certain features off. In the case of the entities sheet (and maybe also the settings sheet), it feels like those patterns are less likely to be used.Entity-related functionality is generally going to be added by defining new columns. For example, we recently introduced
update_if. Because extra columns are ignored, using a form withupdate_ifwith an old version ofpyxformdoes convert the form, it just ignoresupdate_if. It would be more helpful if those forms were rejected instead. It would also be more inline with the versioning scheme for the entities spec and the fact that other consumers of the spec reject versions of the spec newer than they're aware of.The text was updated successfully, but these errors were encountered: