Use asyncio.timeout
instead of asyncio.wait_for
#1246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
asyncio.timeout
instead ofasyncio.wait_for
with a backport-version for python 3.9 and 3.10See python/cpython#98518
I'm not aware of
wait_for
having ever caused bugs in xknx, but I won't be waiting for it either 😉As an extra,
timeout
dosen't spawn extra tasks and the context manager syntax is nicer 🚀Type of change
Checklist