Skip to content

Commit

Permalink
Update flake8 config (python#6684)
Browse files Browse the repository at this point in the history
  • Loading branch information
srittau authored Dec 26, 2021
1 parent 0b3ee98 commit f5059c0
Showing 1 changed file with 19 additions and 13 deletions.
32 changes: 19 additions & 13 deletions .flake8
Original file line number Diff line number Diff line change
@@ -1,26 +1,32 @@
# Some PEP8 deviations are considered irrelevant to stub files:
# E301 expected 1 blank line
# E302 expected 2 blank lines
# E305 expected 2 blank lines
# E701 multiple statements on one line (colon)
# The following rules are incompatible with or enforced by black:
# E203 whitespace before ':' -- scripts only
# E301 expected 1 blank line -- stubs only
# E302 expected 2 blank lines -- stubs only
# E305 expected 2 blank lines -- stubs only
# E501 line too long

# Some rules are considered irrelevant to stub files:
# E701 multiple statements on one line (colon) -- disallows "..." on the same line
# F401 imported but unused -- does not recognize re-exports
# https://github.com/PyCQA/pyflakes/issues/474
# F822 undefined name in __all__ -- flake8 does not recognize 'foo: Any'
# https://github.com/PyCQA/pyflakes/issues/533

# Rules that are out of the control of stub authors:
# E741 ambiguous variable name
# F401 imported but unused
# F403 import *' used; unable to detect undefined names
# F405 defined from star imports
# F822 undefined name in __all__

# Nice-to-haves ignored for now
# E501 line too long

[flake8]
per-file-ignores =
*.py: E203, W503
*.py: E203, E501
*.pyi: E301, E302, E305, E501, E701, E741, F401, F403, F405, F822
# Since typing.pyi defines "overload" this is not recognized by flake8 as typing.overload.
# Unfortunately, flake8 does not allow to "noqa" just a specific error inside the file itself.
# https://github.com/PyCQA/flake8/issues/1079
# F811 redefinition of unused '...'
typing.pyi: E301, E302, E305, E501, E701, E741, F401, F403, F405, F811, F822

# We are checking with Python 3 but many of the stubs are Python 2 stubs.
builtins = StandardError,apply,basestring,buffer,cmp,coerce,execfile,file,intern,long,raw_input,reduce,reload,unichr,unicode,xrange
builtins = buffer,file,long,raw_input,unicode,xrange
exclude = .venv*,.git,*_pb2.pyi
max-line-length = 130

0 comments on commit f5059c0

Please sign in to comment.