Use shlex.quote to convert the arguments into unix format
#209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dachengx
commented
Sep 9, 2024
|
|
||
| if run_on_submit_node: | ||
| job.add_selector_profile(execution_site="local") | ||
| # no other attributes on a local job | ||
| return job | ||
|
|
||
| job.add_profiles(Namespace.CONDOR, "request_cpus", f"{cores}") |
There was a problem hiding this comment.
request_cpus can not be assigned to a local job.
dachengx
commented
Sep 9, 2024
| disk=self.combine_disk, | ||
| run_on_submit_node=True, | ||
| ) | ||
| separate_job = self._initialize_job(name=separate_name, run_on_submit_node=True) |
There was a problem hiding this comment.
For separation jobs, these arguments are not really used.
dachengx
commented
Sep 9, 2024
| return tuple( | ||
| f"{json.dumps(str(d[key])).replace(' ', '')}".replace("'", '\\"') | ||
| for key in d.keys() | ||
| shlex.quote(Submitter.arg_to_str(kwargs[arg], annotation)) |
There was a problem hiding this comment.
Similar to
Line 579 in 09f35f5
dachengx
commented
Sep 9, 2024
| @@ -2,6 +2,12 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| # Check if number of arguments passed is correct | |||
| if [ $# -ne 21 ]; then | |||
There was a problem hiding this comment.
Check the number of arguments.
Pull Request Test Coverage Report for Build 10780496412Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we might see a problem when interpreting the inputs for
alea/submitters/run_toymc_wrapper.sh.