-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config : Airtable.s + Node for dynamic content importing #50
Closed
Closed
Changes from 3 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
3d16eb1
Add airtable dependency, along with new package and package-lock file…
pkane 762a64a
Swap require import for Airtable.js CDN import
curt-mitch-census cd67fac
Add Curtis Airtable API token
curt-mitch-census 4145e9a
Update base ID
curt-mitch-census 26fc195
Updates to API to get first 6 records of site content
curt-mitch-census cc80724
Create xdContent object from record fields. Render test data to 'more…
pkane 0646e96
Separate the content and markup creation logic. Create separate condi…
pkane d4d2420
Test parsing of image content, adding image tags to page.
pkane 0441f45
Merge branch 'master' into at-integration-curtis
pkane e31ad79
Create node script to read from airtable, write cache json file from …
pkane 0b324dc
Merge branch 'master' of github.com:XDgov/xd.gov into at-integration-…
pkane 367b75a
Create structure for generating markup and writing to news, bios mark…
pkane cce4276
Use deepCompare function to compare to cache, handle accordingly
pkane de1f12f
Remove test js from javascript include file
pkane 57a5099
Cleanup logs
pkane dfbe1f0
Restore master version of home and apply page files.
pkane 712af6e
Create workflow folder and test airtable action
pkane 0366c46
Gemfile lockfile update platforms list
pkane 24092c2
Restore liquid dependency version. Rename airtable action
pkane d8015f9
Add npm install step to actions
pkane 94350ef
Update airtable.yml
ian-gov adc8c55
Update airtable.js
ian-gov fd8164d
Update config file to build from new import collections files. Update…
pkane 64a561c
Merge branch 'at-integration-curtis' of github.com:XDgov/xd.gov into …
pkane 9de6e7f
Adjust markup concatenation in string literal to fix formatting issue…
pkane ddb8510
Updated cache and markdown files
pkane f0630b5
Create new layout type for bios. Add simple grid styling.
pkane ddb6a8d
Restore private key lookup
pkane ad47270
Update workflow to create new pr after building
pkane 6fc0a3d
Replace pr step with CPR marketplace action
pkane f234501
Update gitignore with vendor and .bundle folders
pkane e0714a0
Create new news landing layout type, update config
pkane 12355a8
Update airtable script to include image alt attributes. Commit cache …
pkane 23f0e99
Comment out hiring include within new layouts
pkane 05360e6
Cleanup anonymous functions for consistency.
pkane 4d37ac0
leverage object destructuring for cleaner markup construction functions
pkane 4fb425c
Update airtable workflow with named jekyll build step
pkane 3d2ccbc
Update bios and cache file
pkane 4b744d9
Update ruby version
pkane ffc4563
Refactor object prototype call to use json stringify and array isarray
pkane 1a5adf4
Airtable console comment
pkane dcb672d
Fix typeof erroneous change
pkane 6213aa0
Liquid dependency version update
pkane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.1.3 | ||
3.2.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should be more explicit for this line since the
JSON.stringify
method shouldn't ever return'[object Object]'
. Here we should probably usetypeof
like so:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, sorry about that! I haphazardly grouped that in with the other changes.