Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The value of hidden in the config file is not respected #1092

Closed
SVendittelli opened this issue May 6, 2024 · 0 comments · Fixed by #1093
Closed

The value of hidden in the config file is not respected #1092

SVendittelli opened this issue May 6, 2024 · 0 comments · Fixed by #1093

Comments

@SVendittelli
Copy link
Contributor

SVendittelli commented May 6, 2024 •
edited
Loading

Summary

The value of hidden is not read from the config file (neither tokei.toml nor .tokeirc). The hidden field is documented on Struct tokei::Config.

Expected behaviour

Running tokei with the following tokei.toml should have the same effect as running tokei --hidden:

hidden = true

Actual behaviour

The value of hidden is ignored, setting hidden = true does not change the output of tokei.

Steps to reproduce

  1. In an empty directory, create tokei.toml with the following contents: 
    hidden = true
  2. Create .hidden.toml with the following contents: 
    test = "data"
  3. Run tokei: 
    ===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 TOML                    1            1            1            0            0
===============================================================================
 Total                   1            1            1            0            0
===============================================================================
  4. Run tokei --hidden: 
    ===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 TOML                    2            2            2            0            0
===============================================================================
 Total                   2            2            2            0            0
===============================================================================
SVendittelli added a commit to SVendittelli/tokei that referenced this issue May 6, 2024
@SVendittelli
fix: read hidden from config file
fc29b7a 
Previously, setting `hidden = true` in the config file would have no
effect. Now it is properly read.

Fixes: XAMPPRocky#1092
@SVendittelli SVendittelli mentioned this issue May 6, 2024
Merged
SVendittelli added a commit to SVendittelli/tokei that referenced this issue May 6, 2024
@SVendittelli
fix: read hidden from config file
7d491bb 
Previously, setting `hidden = true` in the config file would have no
effect. Now it is properly read.

Fixes: XAMPPRocky#1092
XAMPPRocky pushed a commit that referenced this issue May 13, 2024
@SVendittelli
fix: read hidden from config file (#1093)
eae5e4c 
Previously, setting `hidden = true` in the config file would have no
effect. Now it is properly read.

Fixes: #1092
ErikSchierboom pushed a commit to exercism/tokei that referenced this issue Jun 7, 2024
@SVendittelli @ErikSchierboom
fix: read hidden from config file (XAMPPRocky#1093)
87277e5 
Previously, setting `hidden = true` in the config file would have no
effect. Now it is properly read.

Fixes: XAMPPRocky#1092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: read hidden from config file SVendittelli/tokei
1 participant
@SVendittelli