Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repository secrets api #399

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Add repository secrets api #399

merged 4 commits into from
Jul 8, 2023

Conversation

alesharik
Copy link
Contributor

Adds API to get, create and delete repository secrets; similar to organization secrets API

XAMPPRocky
XAMPPRocky reviewed Jun 22, 2023
View reviewed changes
Copy link
Owner

@XAMPPRocky XAMPPRocky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! LGTM, I would just remove some of the variable declarations in the examples, you're supposed to chain the methods together.

src/api/repos/secrets.rs Outdated Show resolved Hide resolved
src/api/repos/secrets.rs Outdated Show resolved Hide resolved
src/api/repos/secrets.rs Outdated Show resolved Hide resolved
@alesharik alesharik requested a review from XAMPPRocky June 22, 2023 18:28
@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 4b8bd44 into XAMPPRocky:main Jul 8, 2023
@github-actions github-actions bot mentioned this pull request Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XAMPPRocky XAMPPRocky Awaiting requested review from XAMPPRocky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alesharik @XAMPPRocky