add some of the missing fields to PullRequest

[0xB10C]

This adds some of the fields that are missing from the PullRequest model but are present in the GitHub API response. However, I haven't checked if all fields from the API are present in the model now.

The docs can be found here https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#get-a-pull-request

[maflcko]

Are you sure those are options?

I guess it doesn't hurt too much if they are Option<>, but on upstream they seem not.

[0xB10C]

Based on my recent experience using the GitHub API, it's not always given that even if the field should always be set, it is always set (see e.g. #388). Though I agree that it's likely not needed here. I'll do a test-run without Options on my use-case and see if there are any nulls returned.

[maflcko]

Ok, nvm. Either way is fine by me. I think there are other places in octocrab that use Option where the upstream api field is not documented as optional.

[XAMPPRocky]

Thank you for your PR! Is there a reason you marked the PR as a draft?

[0xB10C]

Is there a reason you marked the PR as a draft?

Wanted to verify if the Option around the fields is needed before this is merged.

Turns out, it's needed. The API does not return e.g. additions when listing pull requests with https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-pull-requests but does return additions when getting a single pull request with https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#get-a-pull-request.

[XAMPPRocky]

Thank you for your PR!