Add tracing to requests #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
reviewed
Feb 25, 2023
XAMPPRocky
reviewed
Feb 25, 2023
Cargo.toml
Outdated
| @@ -48,6 +49,7 @@ wiremock = "0.5.3" | |||
| [features] | |||
| default = ["native-tls"] | |||
| rustls = ["rustls-tls"] # Leagcy support (<=0.17.0) | |||
| trace = ["tracing"] | |||
There was a problem hiding this comment.
This shouldn't be needed as by default making tracing optional creates a feature called tracing.
Suggested change
| trace = ["tracing"] |
There was a problem hiding this comment.
I decided to just remove the feature and make it part of the library. Would that be OK?
XAMPPRocky
reviewed
Feb 25, 2023
src/lib.rs
Outdated
| @@ -893,6 +899,38 @@ impl Octocrab { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "trace")] | |||
There was a problem hiding this comment.
Suggested change
| #[cfg(feature = "trace")] | |
| #[cfg(feature = "tracing")] |
XAMPPRocky
reviewed
Feb 25, 2023
src/lib.rs
Outdated
Comment on lines
182
to
185
| #[cfg(feature = "trace")] | ||
| use tracing::{self, field}; | ||
|
|
||
| #[cfg(feature = "trace")] |
There was a problem hiding this comment.
Suggested change
| #[cfg(feature = "trace")] | |
| use tracing::{self, field}; | |
| #[cfg(feature = "trace")] | |
| #[cfg(feature = "tracing")] | |
| use tracing::{self, field}; | |
| #[cfg(feature = "tracing")] |
XAMPPRocky
reviewed
Feb 25, 2023
src/lib.rs
Outdated
| result | ||
| } | ||
|
|
||
| #[cfg(not(feature = "trace"))] |
There was a problem hiding this comment.
Suggested change
| #[cfg(not(feature = "trace"))] | |
| #[cfg(not(feature = "tracing"))] |
Make it a feature so people can opt-in
goodspark
commented
Feb 25, 2023
| } | ||
| }; | ||
| result | ||
| } |
There was a problem hiding this comment.
Had to pull things out to a sep async function because span would've moved if I used .instrument(span), which then prevents recording fields after the request.
|
Also, sorry about the few force pushes. Thought I still had some time to do some last minute tweaks. |
|
Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it a feature so people can opt-inDecided to simplify