Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.41 hard depends on aws-lc-sys, which cannot cross-compile to arm #706

Closed
theRookieCoder opened this issue Oct 2, 2024 · 1 comment · Fixed by #709
Closed

Comments

@theRookieCoder
Copy link

theRookieCoder commented Oct 2, 2024

The new octocrab 0.41 release results in a hard dependency on aws-lc-sys via hyper-rustls when using the rustls feature:

hyper-rustls = { version = "0.27.0", optional = true }

Unfortunately, limitations in cargo mean that it is impossible for upstream crates to not depend on aws-lc-sys without patching the dependency (octocrab in this case). It seems the solution is to turn off default features for that dependency, use neither ring nor aws-lc, and instead let the consumer decide.

@XAMPPRocky
Copy link
Owner

XAMPPRocky commented Oct 2, 2024

Thank you for your issue! Yeah, we can remove default features for hyper-rustls and then expose a set of features which allows people to pick which backend they'd prefer, and we can set the default to the one that has the most broad platform support.

benpueschel added a commit to benpueschel/octocrab that referenced this issue Oct 6, 2024
Remove hard-dependency on `aws-lc-sys` adding two new features:
`rustls-ring` and `rustls-aws-lc-rs`.

By default, `rustls-aws-lc-rs` is enabled (which is also a default
feature for `hyper-rustls`), but the dependency on aws-lc-rs can be
overriden by consumers of the library.

Refs: XAMPPRocky#706
benpueschel added a commit to benpueschel/octocrab that referenced this issue Oct 6, 2024
Remove hard-dependency on `aws-lc-sys` by adding two new features:
`rustls-ring` and `rustls-aws-lc-rs`.

By default, `rustls-aws-lc-rs` is enabled (which is also a default
feature for `hyper-rustls`), but the dependency on aws-lc-rs can be
overriden by consumers of the library.

Refs: XAMPPRocky#706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants