You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hyper-rustls = { version = "0.27.0", optional = true }
Unfortunately, limitations in cargo mean that it is impossible for upstream crates to not depend on aws-lc-sys without patching the dependency (octocrab in this case). It seems the solution is to turn off default features for that dependency, use neither ring nor aws-lc, and instead let the consumer decide.
The text was updated successfully, but these errors were encountered:
Thank you for your issue! Yeah, we can remove default features for hyper-rustls and then expose a set of features which allows people to pick which backend they'd prefer, and we can set the default to the one that has the most broad platform support.
benpueschel
added a commit
to benpueschel/octocrab
that referenced
this issue
Oct 6, 2024
Remove hard-dependency on `aws-lc-sys` adding two new features:
`rustls-ring` and `rustls-aws-lc-rs`.
By default, `rustls-aws-lc-rs` is enabled (which is also a default
feature for `hyper-rustls`), but the dependency on aws-lc-rs can be
overriden by consumers of the library.
Refs: XAMPPRocky#706
benpueschel
added a commit
to benpueschel/octocrab
that referenced
this issue
Oct 6, 2024
Remove hard-dependency on `aws-lc-sys` by adding two new features:
`rustls-ring` and `rustls-aws-lc-rs`.
By default, `rustls-aws-lc-rs` is enabled (which is also a default
feature for `hyper-rustls`), but the dependency on aws-lc-rs can be
overriden by consumers of the library.
Refs: XAMPPRocky#706
The new
octocrab 0.41
release results in a hard dependency onaws-lc-sys
viahyper-rustls
when using therustls
feature:octocrab/Cargo.toml
Line 41 in 9fbf59c
Unfortunately, limitations in cargo mean that it is impossible for upstream crates to not depend on
aws-lc-sys
without patching the dependency (octocrab
in this case). It seems the solution is to turn off default features for that dependency, use neitherring
noraws-lc
, and instead let the consumer decide.The text was updated successfully, but these errors were encountered: