-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature enhance lex:loc with direct Binding / MVVM #241
Conversation
What is Binding? I don't know it as wpf is not my area I work with since a long time. Could you explain it to me a bit? |
Great! Go for it. |
|
Well, I thought Binding is a new class in wpf and I wasn't aware that a direct usage of Binding was possible. |
|
@konne i see! this is a really neat solution! |
|
||
public override object ProvideValue(IServiceProvider serviceProvider) | ||
{ | ||
return new PrependTypeConverter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here can be used "this". It will allow to create less objects. Also this code can be moved in separate class "BaseConverter" and used here and in TranslateConverter
This is a wonderful change! There are many places in our project where we use LocProxy because LocExt doesn't support bindings! |
reduce amount of objetcs with this
@Karnah thanks for you improvement idea. Is already integrated. My plan is to add the docu changes and make a preRelease this week. I appreciate your feedback of usage in your project |
@konne, thanks, we'll try to update on next week |
see Sample
that
{lex:loc {Binding Foo}}
is now perfect working