Initial pass at fixing flake8 issues and adding type annotations #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vbhavank Here is where I'm making an initial pass at type annotation and attachment to the current SMQTK-* modules as base dependencies. |
|
This pull request introduces 2 alerts and fixes 9 when merging 2a62b51 into 9d5c265 - view on LGTM.com new alerts:
fixed alerts:
|
Attempting an initial pass at resolving mypy issues as they crop up, though I do not expect to clear them all right now due to the initial pass qualification.
|
This pull request fixes 10 alerts when merging 240e6ee into 9d5c265 - view on LGTM.com fixed alerts:
|
|
@vbhavank This is good to go now for the purpose of this branch. |
Closed
5 tasks
|
Unit tests are expected to fail because there are no unit tests (no tests == failure). |
Purg
added a commit
that referenced
this pull request
Jun 18, 2021
Initial pass at fixing flake8 issues and adding type annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting an initial pass at resolving mypy issues as they crop up,
though I do not expect to clear them all right now due to the initial
pass qualification.