Add build requirements #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ranikay Sorry for the tag, but we weren't sure who (if anyone) was still actively maintaining this in the Wyss group |
|
@grinner 🙏 |
The most canonical documention of the issue I could find: pypa/setuptools#3693 Also adds a dependency on `wheels` to silence some pip warnings. https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/#fallback-behaviour
mpcusack-color
force-pushed
the
master
branch
from
6211b83 to
b254233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
pyproject.tomlcontaining build time requirements. This is needed becausesetup.pyimports fromnumpywhich won't be installed in a fresh venv. This made this library (and packages that depend on it- in our case aldy) difficult to package without a custom build process.With this change doing a
pip install path/to/ssw-pyin a fresh venv works without first installing numpy and cython.