Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling of Unexpected termination of child #46

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

woytam
Copy link

@woytam woytam commented Oct 29, 2019

Handle Unexpected child termination (when child process is killed for example) and keep number of processes upper Options::MIN_SIZE.
todo: No tests committed.

Handle Unexpected child termination and keep number of processes upper Options::MIN_SIZE
Copy link
Owner

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 👍 ! Looks mostly good, one parser error tho. Also would love to have tests for this, glad to help out with that is you get stuck

src/Manager/Flexible.php Show resolved Hide resolved
src/Manager/Flexible.php Outdated Show resolved Hide resolved
Parse error fixed

Co-Authored-By: Cees-Jan Kiewiet <[email protected]>
@woytam
Copy link
Author

woytam commented Dec 13, 2019

I'm sorry, but tests are too complicated for me.

@WyriHaximus
Copy link
Owner

No problem I'll have a look at it soon

@boring-cyborg boring-cyborg bot added PHP 🐘 Hypertext Pre Processor Source 🔮 labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 🐘 Hypertext Pre Processor Source 🔮
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants