fix(map): add an additional setStyle() call to prevent map loading issues... #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly mapbox logs an error, if we do a |
|
I thought a bit about this. It could be okay if we do this only when running on IE11... Did you close it because it's not needed anymore? |
|
No I closed it because I was not able to fix the e2e test. The e2e tests check the log output and mapbox throws an (IMO unnecessary) error that I can not prevent :-/ Maybe you have an idea for the e2e tests? |
|
e2e tests only run on chrome, so it's fine if we add a check for IE11 |
|
ah I see. I will include an IE check then! |
…vent map loading issues on IE11 (see mapbox/mapbox-gl-js#4821 (comment))
sroettering
force-pushed
the
fix_internet_explorer_style
branch
from
d4d7724
to
086d709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on IE11 (see mapbox/mapbox-gl-js#4821 (comment)).
Main issue is here: mapbox/mapbox-gl-js#4623
Fixes #66