-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pitch/rotation alignment options to Marker component. #226
Conversation
Any news on this ? Did you see my last changes ? |
I'm sorry, but i'm in a bit of a hurry with my own project at the moment. But i'll absolutely try to review it in next 2-3 days. If you absolutely need this in your prod before that, just make a private build. You can get some useful info regarding that here: https://github.com/Wykks/ngx-mapbox-gl/blob/master/DEVELOPER.md Sorry again. |
It works on my machine but I can't push it to master due to incompatible dependencies until the npm package can be updated. I'll work on something else in the meantime |
@webberig Please undo your yarn.lock changes (I, for some reason, do not have rights for that), as they conflict with the latest master and prevent merge. As soon as that is done, i will merge and publish, |
Done! Make sure to upgrade @types/mapbox-gl afterwards, otherwise tsc will probably fail |
ngx-mapbox-gl has some missing options in the marker component that I need, so I added them.
See: https://docs.mapbox.com/mapbox-gl-js/api/markers/#marker