Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pitch/rotation alignment options to Marker component. #226

Merged
merged 4 commits into from
Jun 18, 2020

Conversation

webberig
Copy link
Contributor

@webberig webberig commented Jun 7, 2020

ngx-mapbox-gl has some missing options in the marker component that I need, so I added them.

See: https://docs.mapbox.com/mapbox-gl-js/api/markers/#marker

@webberig
Copy link
Contributor Author

Any news on this ? Did you see my last changes ?
I'd like to implement this in my own project

@dmytro-gokun
Copy link
Collaborator

dmytro-gokun commented Jun 15, 2020

Any news on this ? Did you see my last changes ?
I'd like to implement this in my own project

I'm sorry, but i'm in a bit of a hurry with my own project at the moment. But i'll absolutely try to review it in next 2-3 days. If you absolutely need this in your prod before that, just make a private build. You can get some useful info regarding that here: https://github.com/Wykks/ngx-mapbox-gl/blob/master/DEVELOPER.md

Sorry again.

@webberig
Copy link
Contributor Author

It works on my machine but I can't push it to master due to incompatible dependencies until the npm package can be updated.

I'll work on something else in the meantime

@dmytro-gokun
Copy link
Collaborator

@webberig Please undo your yarn.lock changes (I, for some reason, do not have rights for that), as they conflict with the latest master and prevent merge. As soon as that is done, i will merge and publish,

@webberig
Copy link
Contributor Author

@webberig Please undo your yarn.lock changes (I, for some reason, do not have rights for that), as they conflict with the latest master and prevent merge. As soon as that is done, i will merge and publish,

Done! Make sure to upgrade @types/mapbox-gl afterwards, otherwise tsc will probably fail

@dmytro-gokun dmytro-gokun merged commit 1a61e62 into Wykks:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants