Add popupShown Input binding to marker.component #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable opening and closing marker popups with Input variable
|
Feature request: I was disappointed that popups couldn't be opened by binding a variable to the markers (like in Angular Google Maps) so I added an @input variable ('popupShown') to enable dynamic opening and closing of marker popups, without having to click on the markers. There's only three new lines of code, shouldn't interfere with anything else :) |
|
@Wykks the check fails on the markercluster.component.ts file, which I haven't made any changes to. Any idea what it could be |
|
Hi! Don't worry about travis, I'll do something about that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable opening and closing marker popups with Input variable