New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug? mgl-layer 'type' is required #4

Closed

Tobbyte opened this issue Nov 15, 2017 · 1 comment

Tobbyte commented Nov 15, 2017

The wiki doesn't explicit tells that it's required, but more so:

LayerComponent {
[...]
  @Input() type?: 'symbol ....'
}

the Input for type shouldn't be optional.

Tested with demo/geojson-line : removing type: "line" results in no line drawn.

The text was updated successfully, but these errors were encountered:

Owner

Wykks commented Nov 17, 2017

Indeed, I blindly followed @types/mapbox-gl there which blindly followed the official spec https://www.mapbox.com/mapbox-gl-js/style-spec#layer-type
Not a big deal, Angular doesn't even check that 😄

Wykks closed this as completed in

8cdc2fa

Wykks pushed a commit that referenced this issue


          fix(layer): type is not optional

b9edaac

fix #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment