-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Zero-pitch change ignored #334
Comments
@YaroslavKormushyn You are probably right and we should use '!= null' comparison for all four parameters. Please go ahead and put up a PR |
YaroslavKormushyn
added a commit
to YaroslavKormushyn/ngx-mapbox-gl
that referenced
this issue
Oct 8, 2021
YaroslavKormushyn
added a commit
to YaroslavKormushyn/ngx-mapbox-gl
that referenced
this issue
Oct 8, 2021
dmytro-gokun
pushed a commit
that referenced
this issue
Oct 8, 2021
Fixed in #335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have found that when setting the
pitch
dynamic property to[0]
the change does not propagate to the map instance. This is because when checking the values of themove
method options we ignore all 'falsy' values instead of checking for an actual value.ngx-mapbox-gl/projects/ngx-mapbox-gl/src/lib/map/map.service.ts
Lines 255 to 263 in e5af644
This check for
zoom
orcenter
makes perfect sense, but forbearing
andpitch
zero values should be taken into account.What do you think?
The text was updated successfully, but these errors were encountered: