Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
AnthonyMacKinnon committed Dec 8, 2020
1 parent 2d29ff8 commit cedc502
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
4 changes: 1 addition & 3 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,5 @@
".ng_build": true
},
"typescript.tsdk": "node_modules/typescript/lib",
"eslint.enable": false,
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true
"eslint.enable": false

This comment has been minimized.

Copy link
@tiukh

tiukh Dec 8, 2020

Pls exclude file :)

This comment has been minimized.

Copy link
@AnthonyMacKinnon

AnthonyMacKinnon Dec 8, 2020

Author Contributor

It is excluded from the PR, you're looking at the commit.

}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class RasterDemSourceComponent implements OnInit, OnDestroy, OnChanges, R
@Input() attribution?: RasterDemSource['attribution'];
@Input() encoding?: RasterDemSource['encoding'];

type: RasterDemSource['type'] = 'raster-dem'; // Just to make ts happy
type: RasterDemSource['type'] = 'raster-dem';

private sourceAdded = false;
private sub = new Subscription();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class RasterSourceComponent implements OnInit, OnDestroy, OnChanges, Rast
@Input() scheme?: RasterSource['scheme'];
@Input() attribution?: RasterSource['attribution'];

type: RasterSource['type'] = 'raster'; // Just to make ts happy
type: RasterSource['type'] = 'raster';

private sourceAdded = false;
private sub = new Subscription();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class VectorSourceComponent implements OnInit, OnDestroy, OnChanges, Vect
@Input() attribution?: VectorSource['attribution'];
@Input() promoteId?: VectorSource['promoteId'];

type: VectorSource['type'] = 'vector'; // Just to make ts happy
type: VectorSource['type'] = 'vector';

private sourceAdded = false;
private sub = new Subscription();
Expand Down

0 comments on commit cedc502

Please sign in to comment.