v1.3.4 replaced my custom header in open socket?

[marain87]

I am using "openSocketWithURLRequest" function with "connectionHeaders" to set my custom header.
It is normal when I am using v1.3.3 or before. But I upgrade to v1.3.4 my custom header seem to be replaced by line 137 in "connect" function ...
Does anyone have the same problem?

line 137:
// Support for Spring Boot 2.1.x
connectionHeaders = [StompCommands.commandHeaderAcceptVersion:"1.1,1.2"]

[WrathChaos]

Hi @marain87,
Looking for it :)

[WrathChaos]

@marain87 Actually you still should be able to use the function with connectionHeaders. There are two methods with "openSocketWithURLRequest".

Line 98

I just overloaded these methods. It should be working. Can you provide me with a basic sample? I can test it for you.

[marain87]

HI @WrathChaos, Thanks for the reply.
Actually, I am using Line 98 function to open Socket with a custom header.
I think that the code should check null and not replace the current header value.

like following :

if (connectionHeaders == nil) {
	connectionHeaders = [StompCommands.commandHeaderAcceptVersion:"1.1,1.2"]
}

or

if (connectionHeaders == nil) {
	connectionHeaders = [:]
}
connectionHeaders![StompCommands.commandHeaderAcceptVersion] = "1.1,1.2"

[WrathChaos]

@marain87 It could be awesome if you have time to make a PR :) If you do not have time, I can add it in the future.

[WrathChaos]

Release 1.3.5 is alive now. Thank you @marain87 🔥

Just closed the issue.