Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the flickering of the FortiusAntGui elements #353

Closed
rocky3355 opened this issue Jan 2, 2022 · 5 comments
Closed

Removing the flickering of the FortiusAntGui elements #353

rocky3355 opened this issue Jan 2, 2022 · 5 comments
Labels

Comments

@rocky3355
Copy link
Contributor

Hi WouterJD,

I am currently trying out your software and I was really impressed that it found and forwarded my old TACX setup immediately! :)

However, I noticed an issue that I could also reproduce on another Win10 machine: The GUI elements of FortiusAnt are flickering. I had a look at the code and noticed that the GUI had no buffering enabled. I created a small PR that activates the double buffering and fixes as well a small problem that came along with it (details in the PRs description).

Would you have a look at the PR and give me some feedback? Thank you!

#352

Best regards,
rocky3355

P.S.: This is my first contribution to a foreign repository ever, so I was not sure if my fork's PR would already draw your attention or I also have to create an issue.

@WouterJD
Copy link
Owner

WouterJD commented Jan 2, 2022

@rocky3355 thank you very much for issue & pr, resolving an issue I knew and could not find a solution for. I will che k asap and let you know

@WouterJD
Copy link
Owner

WouterJD commented Jan 2, 2022

By the way; Welcome to the FortiusANT community


I'm always curious to know who I communicate with, where FortiusANT is used and what configuration is used.
Please tell me what bundle did you buy, and what brake and what head unit do you use?
I would therefore appreciate that you introduce yourself; perhaps leave a comment under issue #14.
You could also consider to visit the sponsor page


@WouterJD
Copy link
Owner

WouterJD commented Jan 4, 2022

I've looked at your PR and if course, if one control is on top of another that must be the parent😝
I'll do further testing and integrate asap

@WouterJD
Copy link
Owner

WouterJD commented Jan 4, 2022

Works like a charm

@WouterJD WouterJD added the solved label Jan 4, 2022
WouterJD added a commit that referenced this issue Jan 4, 2022
* issues #340 #342 #355 implemented

* +exec
@WouterJD WouterJD closed this as completed Jan 4, 2022
@rocky3355
Copy link
Contributor Author

I've looked at your PR and if course, if one control is on top of another that must be the parent😝 I'll do further testing and integrate asap

Hmm I thought that drawing on top of each other should still work, like it did before enabling the buffering. But yes, declaring a parent/child relation is the better solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants