Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-1885: Prop requiredness codemod #290

Merged
merged 91 commits into from
Aug 10, 2024
Merged
Changes from 1 commit
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
dfdeacf
Fix required hint util checking comments for subsequent nodes
greglittlefield-wf Jul 16, 2024
1ddf484
Add constant for late hint
greglittlefield-wf Jul 16, 2024
1660af4
First stab at prop requiredness codemod, using external data
greglittlefield-wf Jul 16, 2024
d1655e2
Update aggregated data format, consume updates
greglittlefield-wf Jul 16, 2024
c07c785
Factor in isPublic and skip rate, default to optional when no data
greglittlefield-wf Jul 16, 2024
514a86b
Improve reason strings
greglittlefield-wf Jul 16, 2024
d28974d
Fix no-data case updating non-props
greglittlefield-wf Jul 16, 2024
0f7d718
Add helpful todo for classes that were skipped
greglittlefield-wf Jul 18, 2024
c1b4df6
Handle missing data case
greglittlefield-wf Jul 18, 2024
e4f4cdd
Update args with recommender options
greglittlefield-wf Jul 22, 2024
4ef3d4e
Re-sync aggregated data format
greglittlefield-wf Jul 22, 2024
b95b461
Clarify message
greglittlefield-wf Jul 22, 2024
2e0247d
Format
greglittlefield-wf Jul 22, 2024
6bac8f9
Don't emit comments on individual props if the whole mixin was skipped
greglittlefield-wf Jul 22, 2024
f9b2c58
Fix inverted boolean
greglittlefield-wf Jul 22, 2024
584e80b
Honor required prop annotations under flag
greglittlefield-wf Jul 22, 2024
60eb48f
Remove requiredProp annotations
greglittlefield-wf Jul 22, 2024
33b45c2
Make TODOs consistent
greglittlefield-wf Jul 22, 2024
6a28031
Reorganize code
greglittlefield-wf Jul 22, 2024
f058c31
Add copyright comments
greglittlefield-wf Jul 22, 2024
6143eb9
Indicate copied files
greglittlefield-wf Jul 22, 2024
4cbb5a6
Support negatable args
greglittlefield-wf Jul 22, 2024
fcf1e5d
Add tests, fix bug in multi-arg option logic
greglittlefield-wf Jul 22, 2024
b144727
Add required props data collection scripts
greglittlefield-wf Jul 23, 2024
6f94adc
Format
greglittlefield-wf Jul 23, 2024
264f767
Add progress log back in
greglittlefield-wf Jul 23, 2024
f3ded7b
Log package specs
greglittlefield-wf Jul 23, 2024
b6f18ed
Add output option to aggregate script
greglittlefield-wf Jul 23, 2024
d4719a7
Allow hosted pub packages in collection script
greglittlefield-wf Jul 24, 2024
ff66c0c
Add help text to collect script
greglittlefield-wf Jul 24, 2024
4f674f2
Add output directory arg to collect script
greglittlefield-wf Jul 24, 2024
9cb548f
Fail collect if no packages are specified
greglittlefield-wf Jul 24, 2024
803be69
Add some tests for required prop data collection and aggregation
greglittlefield-wf Jul 24, 2024
44eecb0
Fix output file not including package name
greglittlefield-wf Jul 24, 2024
3178106
Add tests for visibility data, fix indirectlyPublic visibility
greglittlefield-wf Jul 24, 2024
5e82b7d
Add tests for props with usages in other packages
greglittlefield-wf Jul 30, 2024
043f4c5
Improve directory output
greglittlefield-wf Jul 30, 2024
7a69e89
Add test for non-factory usage filtering
greglittlefield-wf Jul 30, 2024
5821b84
Fix test setup to use test_consuming_package
greglittlefield-wf Jul 30, 2024
bdb3101
Aggregate data by default in collect.dart
greglittlefield-wf Jul 30, 2024
35bba9f
Include stdout on process failure
greglittlefield-wf Jul 30, 2024
ccec045
Add end-to-end test for required props data collection and codemod
greglittlefield-wf Jul 30, 2024
637fd19
Make collect and codemod subcommands of a single executable
greglittlefield-wf Jul 30, 2024
95f8014
Improve invocation line of help output
greglittlefield-wf Jul 30, 2024
d6be7b5
Format
greglittlefield-wf Jul 31, 2024
bc5f078
Add some usage instructions
greglittlefield-wf Jul 31, 2024
935a191
Run pub get in codemod
greglittlefield-wf Jul 31, 2024
197e07d
Rename flag
greglittlefield-wf Jul 31, 2024
4a930d6
Fix inverted boolean
greglittlefield-wf Jul 31, 2024
361feb1
Add test coverage for required annotation logic and flag
greglittlefield-wf Jul 31, 2024
a6709c4
Clean up logging, add verbose flag
greglittlefield-wf Jul 31, 2024
46dacc3
More logging tweaks
greglittlefield-wf Jul 31, 2024
794f29e
Add coloring/formatting to logs
greglittlefield-wf Jul 31, 2024
09dad6d
Log more with verbose:true
greglittlefield-wf Jul 31, 2024
055502a
Fix inverted boolean
greglittlefield-wf Jul 31, 2024
cd3c19c
Set up json_serializable, remove unused mockito whose builder was err…
greglittlefield-wf Jul 31, 2024
f72e4e2
Add CI check for generated changes
greglittlefield-wf Jul 31, 2024
52ff940
Merge remote-tracking branch 'origin/master' into prop-requiredness-c…
greglittlefield-wf Jul 31, 2024
e362ef7
Format
greglittlefield-wf Jul 31, 2024
b8726b9
Update test in response to formatting
greglittlefield-wf Jul 31, 2024
8ad3aad
Add missing dependency
greglittlefield-wf Jul 31, 2024
7c8a02a
Merge branch 'fixes-and-cleanup' into prop-requiredness-codemod-with-…
greglittlefield-wf Aug 1, 2024
1e55e90
Add tests for requiredness threshold options
greglittlefield-wf Aug 1, 2024
c85d6bd
Add tests for skip arguments
greglittlefield-wf Aug 1, 2024
f612d95
Add some doc comments
greglittlefield-wf Aug 1, 2024
bb959d1
Split out aggregation from its executable
greglittlefield-wf Aug 1, 2024
c898f84
Reorganize files
greglittlefield-wf Aug 1, 2024
bd6dbad
Reorganize/rename tests
greglittlefield-wf Aug 1, 2024
97556a0
Fix outdated name in pubspec
greglittlefield-wf Aug 1, 2024
d53328f
Don't write individual results to files by default
greglittlefield-wf Aug 2, 2024
d71085c
Clean up temporary folder when we're done with it
greglittlefield-wf Aug 2, 2024
55565be
Format
greglittlefield-wf Aug 2, 2024
db0f7e1
Fix deletion of non-empty directory failing
greglittlefield-wf Aug 2, 2024
c8f9d98
Merge remote-tracking branch 'origin/master' into prop-requiredness-c…
greglittlefield-wf Aug 2, 2024
134e15c
Add copyright comments
greglittlefield-wf Aug 5, 2024
6ec1504
Update command descriptions
greglittlefield-wf Aug 5, 2024
83a5dc3
Add and improve instructions
greglittlefield-wf Aug 5, 2024
1bb0891
Consolidate copies of get_all_props.dart
greglittlefield-wf Aug 5, 2024
f0f7d11
Remove unused vendored file
greglittlefield-wf Aug 5, 2024
ded4368
Improve test coverage of required annotation tests
greglittlefield-wf Aug 6, 2024
0785240
Align class name with file name and convention
greglittlefield-wf Aug 6, 2024
c223666
Add tests for existing hints, don't short-circuit on non-nullable hints
greglittlefield-wf Aug 6, 2024
407ea41
Add tests for existing hints, don't short-circuit on non-nullable hints
greglittlefield-wf Aug 6, 2024
cbc86da
Clean up .package-cache references, used same temp directory for Git
greglittlefield-wf Aug 6, 2024
900191c
Use dart_dev for formatting so that we can exclude files
greglittlefield-wf Aug 6, 2024
5bf1fc9
Format
greglittlefield-wf Aug 6, 2024
eda7140
Improve instructions, add note about mismatched versions
greglittlefield-wf Aug 6, 2024
50b6fc7
Indicate when using the latest version of a Pub package
greglittlefield-wf Aug 6, 2024
dc5cb89
Display package versions from pubspec.lock, improve logs
greglittlefield-wf Aug 6, 2024
db2dc7e
Update instructions about package mismatches
greglittlefield-wf Aug 6, 2024
6393501
Format
greglittlefield-wf Aug 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add progress log back in
  • Loading branch information
greglittlefield-wf committed Jul 23, 2024
commit 264f7674c2f837689c4df978d3bd4459b8867d2c
3 changes: 2 additions & 1 deletion lib/src/prop_requiredness/collect.dart
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@ import 'package:over_react_codemod/src/util/component_usage.dart';
import 'package:over_react_codemod/src/vendor/over_react_analyzer_plugin/get_all_props.dart';

import 'collected_data.sg.dart';
import 'logging.dart';

Future<PackageResults> collectDataForUnits(
Stream<ResolvedUnitResult> units, {
@@ -29,7 +30,7 @@ Future<PackageResults> collectDataForUnits(
if (unitResult.uri.path.endsWith('.over_react.g.dart')) continue;
if (unitResult.libraryElement.isInSdk) continue;

// logProgress();
logProgress();

//logger.finest('Processing ${unitResult.uri}');