-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otel logs #169
base: master
Are you sure you want to change the base?
Otel logs #169
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
@provRushabhShah Thanks for the contribution, please run |
can we move forward this log feature? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these changes are a work in progress.
We'll want to clean this up and break out the implementation. For starters, we'll want to:
- remove dev env specific files
- ensure added files have the copy write notice at the top and a trailing new line at the end
- folder and file names should be lower case
- break up the changes into multiple PRs for easier review. The first PR I would suggest is the one adding the generated protobuf code
Hi. Can I know if this PR is still ongoing? If not, I would like to start creating PRs for this feature. Currently in my job, I am looking to replace our custom remote log to opentelemetry standard and expected to use it by Q1 this year so I have time to actively work on this. At this point, the codes in my repo worked with OpenTelemetryCollector and Loki as well as visualising Grafana. I am not an expert in this field, so would appreciate for some 👀 and guidance too :) Also thanks to this PR as it helped me a lot on some parts. |
I've create PRs. If this PR continues, then I'll close mine. |
Which problem is this PR solving?
Added Logs in this framework
Added LogExpoter, Provider, Logger object, protobuffer
Checklist: