Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otel logs #169

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

provRushabhShah
Copy link

@provRushabhShah provRushabhShah commented May 20, 2024

Which problem is this PR solving?

Added Logs in this framework
Added LogExpoter, Provider, Logger object, protobuffer

Checklist:

  • Unit tests have been added

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@changliu-wk
Copy link
Contributor

changliu-wk commented May 20, 2024

@provRushabhShah Thanks for the contribution, please run make analyze to fix the CI tests.

@evanweible-wf evanweible-wf removed their request for review July 12, 2024 23:37
@yorkvolvo
Copy link

can we move forward this log feature?

Copy link
Contributor

@blakeroberts-wk blakeroberts-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these changes are a work in progress.

We'll want to clean this up and break out the implementation. For starters, we'll want to:

  • remove dev env specific files
  • ensure added files have the copy write notice at the top and a trailing new line at the end
  • folder and file names should be lower case
  • break up the changes into multiple PRs for easier review. The first PR I would suggest is the one adding the generated protobuf code

@yuzurihaaa
Copy link
Contributor

yuzurihaaa commented Jan 6, 2025

Hi. Can I know if this PR is still ongoing? If not, I would like to start creating PRs for this feature.

Currently in my job, I am looking to replace our custom remote log to opentelemetry standard and expected to use it by Q1 this year so I have time to actively work on this.

At this point, the codes in my repo worked with OpenTelemetryCollector and Loki as well as visualising Grafana.

I am not an expert in this field, so would appreciate for some 👀 and guidance too :)

Also thanks to this PR as it helped me a lot on some parts.

@yuzurihaaa
Copy link
Contributor

I've create PRs. If this PR continues, then I'll close mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants