Create helm chart #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyko
reviewed
Oct 5, 2018
| @@ -0,0 +1,16 @@ | |||
| apiVersion: extensions/v1beta1 | |||
There was a problem hiding this comment.
Might want to wrap this in an if to enable/disable it?
ScottBishop
force-pushed
the
create-helm-chart
branch
from
6a6c36a
to
b431e11
Compare
kennyko
approved these changes
Oct 8, 2018
vizzy/templates/deployment.yaml
Outdated
| app: {{ .Chart.Name }} | ||
| release: {{ .Release.Name }} | ||
| spec: | ||
| volumes: |
There was a problem hiding this comment.
Might want to sort the keys in this block, its a bit odd to have volumes up here
vizzy/values.yaml
Outdated
|
|
||
| volumeMounts: | ||
| name: visual-data | ||
| mountPath: /app/public/visual_images |
There was a problem hiding this comment.
If this path is hardcoded, ie. not configurable in the application, it probably shouldn't be configurable here.
kennyko
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Helm Chart for Vizzy
Helm helps you manage Kubernetes applications — define, install, and upgrade even the most complex Kubernetes application.